cmd: Rewrite #428
Merged
cmd: Rewrite #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n10v
added
area/cobra-command
n10v
force-pushed
the
cmdenhancement
branch
4 times, most recently
from
17eaeed
to
ccb6c50
Compare
This was referenced May 5, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of cobra/cmd was hard to understand and to maintain. There were a lot of global variables, odd function names and etc.
So I decided to rewrite it and make cobra/cmd clearer.
Comments and opinions are welcome!
Fixes #269
Fixes #276
Fixes #321
Fixes #330
Fixes #374
Fixes #430
Closes #335
Closes #351
Closes #375
Closes #381
Huge thanks to @dcu, @MarkDBlackwell, @danesparza, @calvn and @PaluMacil for your bug reports. This is the reason I made this PR! I will appreciate it, if you will test this change and report any problem you experience.
Huge thanks to @elliotmr, @amrfaissal, @irfansharif and @ofpiyush for your contributions and problem solutions. The problem is much bigger and the only solution here is just rewrite whole cobra/cmd. We are really glad of your new contributions, bug reports and feature requests/proposals. Also I will appreciate it, if you will test this change and report any problem you experience.
TODO: