New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node vs Page #2297

Closed

bep opened this issue Jul 21, 2016 · 3 comments · Fixed by #2649

Assignees

Labels

Enhancement Outdated

Member

bep commented Jul 21, 2016 •

edited

Loading

This issue tracks improvements as described in https://discuss.gohugo.io/t/node-improvements/1593

Related issues dangling around will be closed as they must be considered when fixing this.

bep added the Enhancement label

This was referenced Jul 21, 2016

Enable proper titles for Nodes #1051

Closed

Sitemap.xml should include nodes, as well as pages #1303

Closed

Document homepage content workaround #2240

Closed

Allow home page to be easily authored in markdown #720

Closed

Minimalist website with homepage as content #330

Closed

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

0f47387

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

e3f9a54

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Create a Node map to get proper node translations

45f980e

In a multi-language setup, before this commit the Node's Translations() method
would return some "dummy nodes" that would point to the correct page (Permalink),
but would not be the same as the node it points to -- it would not have the translated
title etc.

The node creation is, however, so mingled with rendering, whihc is too early to have any global state,
so the nodes has to be split in a prepare and a render phase. This commits does that with as small
a change as possible. This implementation is a temp solution until we fix #2297.

Updates #2309

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

e7db100

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Create a Node map to get proper node translations

a6845db

In a multi-language setup, before this commit the Node's Translations() method
would return some "dummy nodes" that would point to the correct page (Permalink),
but would not be the same as the node it points to -- it would not have the translated
title etc.

The node creation is, however, so mingled with rendering, whihc is too early to have any global state,
so the nodes has to be split in a prepare and a render phase. This commits does that with as small
a change as possible. This implementation is a temp solution until we fix #2297.

Updates #2309

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

dd3c643

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Create a Node map to get proper node translations

bd0fdaf

In a multi-language setup, before this commit the Node's Translations() method
would return some "dummy nodes" that would point to the correct page (Permalink),
but would not be the same as the node it points to -- it would not have the translated
title etc.

The node creation is, however, so mingled with rendering, whihc is too early to have any global state,
so the nodes has to be split in a prepare and a render phase. This commits does that with as small
a change as possible. This implementation is a temp solution until we fix #2297.

Updates #2309

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

9ffd949

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Create a Node map to get proper node translations

e63e649

In a multi-language setup, before this commit the Node's Translations() method
would return some "dummy nodes" that would point to the correct page (Permalink),
but would not be the same as the node it points to -- it would not have the translated
title etc.

The node creation is, however, so mingled with rendering, whihc is too early to have any global state,
so the nodes has to be split in a prepare and a render phase. This commits does that with as small
a change as possible. This implementation is a temp solution until we fix #2297.

Updates #2309

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

a414c0b

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep added a commit that referenced this issue


          Create a Node map to get proper node translations

1dc571b

In a multi-language setup, before this commit the Node's Translations() method
would return some "dummy nodes" that would point to the correct page (Permalink),
but would not be the same as the node it points to -- it would not have the translated
title etc.

The node creation is, however, so mingled with rendering, whihc is too early to have any global state,
so the nodes has to be split in a prepare and a render phase. This commits does that with as small
a change as possible. This implementation is a temp solution until we fix #2297.

Updates #2309

bep added a commit that referenced this issue


          Add Translations and AllTranslations to Node

3a02807

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for #2297, but the API should be stable.

bep closed this as completed in

a07293c

VoidingWarranties commented Sep 14, 2016

Has this been resolved? Curious because in a07293c the commit message says

... This implementation is a temp solution until we fix #2297.

Member Author

bep commented Sep 14, 2016

No it was closed by mistake.

bep reopened this

bep mentioned this issue

Sitemap priority. Setting a value for the homepage that's different to the default #2622

Closed

bep mentioned this issue

Make Node a Page #2649

Merged

40 tasks

spf13 assigned bep

bep added a commit that referenced this issue


          node to page: Make Nodes into Pages

063b78d

* `.Site.Pages` now contains all page types, including sections etc.
* `.Data.Pages` will also contain "node type" pages where relevant.

Updates #2297

bep added a commit that referenced this issue


          node to page: Add Pages to Page

c80308e

As an alias to .Data.Pages for home page etc.

Also renamte NodeType to PageType and make it a string so it can be used in `where`.

Updates #2297

bep added a commit that referenced this issue


          node to page: Handle Date and Lastmod

487b210

Updates #2297

bep added a commit that referenced this issue


          node to page: Export GetPage to the templates

96f7114

Updates #2297

bep added a commit that referenced this issue


          node to page: Rename PageType to Kind

9fba2a3

And embed that on Page.

Updates #2297

bep added a commit that referenced this issue


          node to page: Make Kind a string

Having a custom string type isn't worth it when it doesn't work
with `where`, `eq` etc.

Fixes #2689
Updates #2297

bep added a commit that referenced this issue


          node to page: Remove Node

c8d3124

And misc. TODO-fixes

Updates #2297

bep added a commit that referenced this issue


          node to page: Handle URLs

524eb16

This includes removing the error return value from Permalink and RelPermalink.

We ignore that error all over the place, so we might as well remove it.

Updates #2297

bep added a commit that referenced this issue


          node to page: Misc. TODO-fixes

62e9e7e

Updates #2297

bep added a commit that referenced this issue


          node to page: Fix the Page copy()

99d1138

By embeding the init sync.Once var in a pointer so we can reset it when we copy the page.

Updates #2297

bep added a commit that referenced this issue


          node to page: Final TODO-fixes

a843d5d

Updates #2297

bep added a commit that referenced this issue


          node to page: Only return regular pages in home.Data.Pages

28031b0

Returning all types is both confusing and too breaking.

All page types can be fetched in .Site.Pages.

Updates #2297

bep added a commit that referenced this issue


          node to page: Need to append theme templates

32fb1e6

Updates #2297

bep added a commit that referenced this issue


          node to page: Render aliases before pages

0bbdcf2

Some sites, Hugo docs included, have faulty alias definitions that point
to itself or another real page. These will be overwritten in the next step.

This is how it behaves in Hugo 0.17, too.

Updates #2297

bep added a commit that referenced this issue


          node to page: Temporary set RSS date to zero

f776af6

Updates #2297

bep added a commit that referenced this issue


          node to page: Don't repeat the RSS title if it is the same

7e81971

Updates #2297

bep added a commit that referenced this issue


          docs: Make the tools content page a section page

ae1de7a

Because it is the right solution and it the avoids naming conflict with section vs page.

Updates #2297

bep added a commit that referenced this issue


          docs: Revise docs to reflect that Node is gone

aafbd3b

Updates #2297

bep added a commit that referenced this issue


          node to page: Fixe index page translation issues

976f8f8

Updates #2297

bep added a commit that referenced this issue


          node to page: Fix site pages sort

0eb5f54

Updates #2297

bep added a commit that referenced this issue


          docs: Add sections on node now being a page

e29f6fe

Updates #2297

bep added a commit that referenced this issue


          docs: Add release notes about node to page

6c0ecc2

Updates #2297

bep added a commit that referenced this issue


          node to page: Re-add translations sort of regular pages

382582f

Was removed by mistake.

Updates #2297

bep added a commit that referenced this issue


          docs: Add Pages to variables section

a5b3b07

And some other minor doc fixes.

Closes #2297
Closes #2649

joneskoo mentioned this issue

Tag names with period broken #3169

Closed

tychoish pushed a commit to tychoish/hugo that referenced this issue


          Add Translations and AllTranslations to Node

6678b2e

This commit also consolidates URLs on Node vs Page, so now .Permalink should be interoperable.

Note that this implementations should be fairly short-livded, waiting for gohugoio#2297, but the API should be stable.

tychoish pushed a commit to tychoish/hugo that referenced this issue


          Create a Node map to get proper node translations

e06776a

In a multi-language setup, before this commit the Node's Translations() method
would return some "dummy nodes" that would point to the correct page (Permalink),
but would not be the same as the node it points to -- it would not have the translated
title etc.

The node creation is, however, so mingled with rendering, whihc is too early to have any global state,
so the nodes has to be split in a prepare and a render phase. This commits does that with as small
a change as possible. This implementation is a temp solution until we fix gohugoio#2297.

Updates gohugoio#2309

github-actions bot commented Mar 31, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions bot added the Outdated label

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.