Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the globals out of site build #2701

Closed
6 tasks done
bep opened this issue Nov 17, 2016 · 3 comments
Closed
6 tasks done

Refactor the globals out of site build #2701

bep opened this issue Nov 17, 2016 · 3 comments
Assignees
@bep
Labels
Enhancement InProgress Outdated
Milestone
v0.19

Comments

@bep
Copy link
Member

bep commented Nov 17, 2016 •
edited
Loading

There currently is a controlled, but careful, dance in the tests to set a set of global state before each test. While this is controlled and has no performance impact for the end result, it it not best practice, it is hard to reason about and it prevents us from using t.Parallel to potentially speed up the test suite.

We have done some considerably work around this area, so when we get some of the big PRs in the pipeline merged, it may be time.

From my head this means:

  • HugoSites should contain:
  • viper
  • template
  • hugofs
  • jww logger
  • translator/i18n bundles handling
  • image config cache

There are plenty of details left out in the above, but it should be complete in general.
@bep bep self-assigned this Nov 17, 2016
@bep bep mentioned this issue Nov 25, 2016
Closed
@bep bep added this to the v0.19 milestone Jan 1, 2017
@bep bep mentioned this issue Jan 1, 2017
Closed
@bep bep added the InProgress label Jan 3, 2017
bep added a commit that referenced this issue Jan 3, 2017
@bep
commands, helpers, vendor: Update to the latest jww logger
c344b19 
Updates #2701
bep added a commit to bep/hugo that referenced this issue Jan 6, 2017
@bep
all: Refactor to non-global logger
363df2c 
Updates gohugoio#2701
@bep bep mentioned this issue Jan 6, 2017
Closed
@bep bep mentioned this issue Jan 7, 2017
Merged
bep added a commit to bep/hugo that referenced this issue Jan 7, 2017
@bep
all: Refactor to non-global logger
bd2596c 
Note that this looks like overkill for just the logger, and that is correct,
but this will make sense once we start with the template handling etc.

Updates gohugoio#2701
bep added a commit that referenced this issue Jan 7, 2017
@bep
all: Refactor to non-global logger
45e3ed5 
Note that this looks like overkill for just the logger, and that is correct,
but this will make sense once we start with the template handling etc.

Updates #2701
bep added a commit to bep/hugo that referenced this issue Jan 9, 2017
@bep
all: Refactor to nonblogal template handling
650c02d 
Updates gohugoio#2701
@bep bep mentioned this issue Jan 9, 2017
Merged
bep added a commit that referenced this issue Jan 10, 2017
@bep
all: Refactor to nonglobal template handling
d6000a2 
Updates #2701
bep added a commit to bep/hugo that referenced this issue Feb 3, 2017
@bep
all: Refactor to nonglobal file systems
ba139ab 
Updates gohugoio#2701
Fixes gohugoio#2951
bep added a commit that referenced this issue Feb 4, 2017
@bep
all: Refactor to nonglobal file systems
c71e1b1 
Updates #2701
Fixes #2951
@bep bep mentioned this issue Feb 5, 2017
Merged
bep added a commit to bep/hugo that referenced this issue Feb 17, 2017
@bep
all: Refactor to nonglobal Viper, i18n etc.
2bc61c8 
This is a final rewrite that removes all the global state in Hugo, which also enables
the use if `t.Parallel` in tests.

Updates gohugoio#2701
Fixes gohugoio#3016
bep added a commit to bep/hugo that referenced this issue Feb 17, 2017
@bep
tpl: Refactor package
c8988f2 
Now:

* The template API lives in /tpl
* The rest lives in /tpl/tplimpl

This is bound te be more improved in the future.

Updates gohugoio#2701
bep added a commit to bep/hugo that referenced this issue Feb 17, 2017
@bep
tplimpl: Refactor imageConfig into a struct
220253c 
Updates gohugoio#2701
@bep bep closed this as completed Feb 17, 2017
bep added a commit that referenced this issue Feb 17, 2017
@bep
all: Refactor to nonglobal Viper, i18n etc.
93ca7c9 
This is a final rewrite that removes all the global state in Hugo, which also enables
the use if `t.Parallel` in tests.

Updates #2701
Fixes #3016
bep added a commit that referenced this issue Feb 17, 2017
@bep
tpl: Refactor package
c507e27 
Now:

* The template API lives in /tpl
* The rest lives in /tpl/tplimpl

This is bound te be more improved in the future.

Updates #2701
bep added a commit that referenced this issue Feb 17, 2017
@bep
tplimpl: Refactor imageConfig into a struct
77cbe4d 
Updates #2701
@n10v
Copy link
Contributor

n10v commented Feb 19, 2017 •
edited
Loading

I think, it would be better to rename and Deps(Cfg).Cfg to Deps(Cfg).Provider. The provider means, what it provides the config.
It should be renamed, because cfg.Cfg says nothing.

@bep
Copy link
Member Author

bep commented Feb 19, 2017

You should create a new issues for new issues, a closed issue is ... closed.

However, provider does not tell what it provides -- Cfg at least tell that it contains configuration.

@n10v n10v mentioned this issue Feb 19, 2017
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement InProgress Outdated
Projects
None yet
Milestone
v0.19
Development

No branches or pull requests
2 participants
@bep @n10v