Properly handle temp files while rebuilding #2179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, any error during rereading would cause Hugo to hang. Fixes #2168
|
Yes, I can understand that ... the easiest to fix is the hardest to track. The commits looks fine; I can merge this, but we should let this linger for a day until we release. |
tychoish
pushed a commit
to tychoish/hugo
that referenced
this pull request
Aug 13, 2017
Without this fix, any error during rereading would cause Hugo to hang. Fixes gohugoio#2168 Closes gohugoio#2179
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bep The fix turned out to be pretty simple, but it took a while to identify the cause.
I've kept this as 3 commits because I feel they are 3 independent changes which address different issues, but together they resolve the general issue of temp file handling. I can squash if you prefer.