Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make x.Parsed() return true after AddGoFlagSet(x) and pflag.Parse() #162

Merged
merged 3 commits into from
Apr 3, 2018

Conversation

childe
Copy link

@childe childe commented Apr 3, 2018

some third party lib such as glog use go flag package, and its some
actions depend on what goflag.Parsed() returns.

some third part lib such as glog use go flag package, and its some
actions depends on if goflag.Parsed().
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2018

CLA assistant check
All committers have signed the CLA.

@eparis
Copy link
Collaborator

eparis commented Apr 3, 2018

I like it. But what happens if someone is already using the goflag.Parse(nil) trick in their own code. Will calling it again in our code cause them a problem?

@eparis
Copy link
Collaborator

eparis commented Apr 3, 2018

Ok, It doesn't seem that goflag cares if you parse more than once. I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants