Replace "." characters with "_" when parsing environment variables #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 18, 2016 21:24
The field is being added in preparation for testing nested key parsing from environment variables.
Add a test where an environment variable with a nested key is set and then retrieved. The nested key uses an underscore in place of a dot to indicate the key hierarchy.
This brings viper in line with other configuration parsing libraries and in line with what I would anticipate are the expectations of most programms.
|
|
|
I'm waiting on clearance from my work to sign the CLA. Should have it today or tomorrow. Would love some comments on the patch in the interim. |
|
Why not just use |
|
Yeah, that seems to be the route forward. I need to rework this when I have a bit more time. Thanks for the suggestion. |
|
I intend to rework this patch to remove my code change and to update the test cases to use SetEnvReplacer , as suggested. That would (IMHO) add value as an example of how to solve this issue and as a valuable test case. |
|
If you still want to write test cases for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the parsing of environment variables that correspond to nested keys. This seems like a safe conversion since "." is not allowed in environment variables.