Properly handle string slice values #296
Conversation
|
|
|
Nice, I was just coming to see if any progress had been made on this yet. Hoping to see this merged soon :-) |
| @@ -880,7 +881,9 @@ func (v *Viper) find(lcaseKey string) interface{} { | |||
| return cast.ToBool(flag.ValueString()) | |||
| case "stringSlice": | |||
| s := strings.TrimPrefix(flag.ValueString(), "[") | |||
| return strings.TrimSuffix(s, "]") | |||
| s = strings.TrimSuffix(s, "]") | |||
| res, _ := readAsCSV(s) | |||
There was a problem hiding this comment.
Thinking out loud: maybe the error should not be silently ignored but shouted loudly as panic? Any thoughts?
There was a problem hiding this comment.
We silently swallow errors in the other cases, so ...
There was a problem hiding this comment.
Ok, let's be consistent ;)
| @@ -880,7 +881,9 @@ func (v *Viper) find(lcaseKey string) interface{} { | |||
| return cast.ToBool(flag.ValueString()) | |||
| case "stringSlice": | |||
| s := strings.TrimPrefix(flag.ValueString(), "[") | |||
| return strings.TrimSuffix(s, "]") | |||
| s = strings.TrimSuffix(s, "]") | |||
| res, _ := readAsCSV(s) | |||
There was a problem hiding this comment.
Ok, let's be consistent ;)
|
@bep what about the merge? ;-) |
|
Would love to see this be merged soon. |
|
@bep Hey there, just wanted to ping you again to see if you'd be interested in merging this! I'm hitting this issue in a new piece of software I'm writing, and would like to use |
The previous vendored `github.com/spf13/viper` had this bug spf13/viper#296 . This commit upgrades to the latest `github.com/spf13/viper` and closes kubernetes#1797.
The previous vendored `github.com/spf13/viper` had this bug spf13/viper#296 . This commit upgrades to the latest `github.com/spf13/viper` and closes kubernetes#1797.
Added a code handling a pflag.StringSlice values. Also tested most cases.
It fixes #200.
Similar to: #244