Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.4.0 #434

Closed
5 tasks done
lan496 opened this issue Feb 15, 2024 · 12 comments · Fixed by #467
Closed
5 tasks done

Release v2.4.0 #434

lan496 opened this issue Feb 15, 2024 · 12 comments · Fixed by #467

Comments

@lan496
Copy link
Member

lan496 commented Feb 15, 2024

Let's release type check (merged in #420) because the recent drop of ase.Atoms seems to cause surprise to not a few users.

TODO

@LecrisUT @atztogo Do you have any leftovers for the next minor version?

@atztogo
Copy link
Collaborator

atztogo commented Feb 15, 2024

Thanks @lan496. Let's do it.

@LecrisUT
Copy link
Collaborator

On my side only #308, everything else can be bumped up

@LecrisUT
Copy link
Collaborator

LecrisUT commented Feb 15, 2024

Let's see how #435 goes, if all goes well, it would make sense to include it as well.

Edit: It actually works, so let's add it in as well
Edit2: Might be worth having #437 as well. That one solves a windows issue

@LecrisUT
Copy link
Collaborator

Small note, @lan496 when you make the release note, check that they are in order and not duplicated

@lan496
Copy link
Member Author

lan496 commented Feb 15, 2024

Thank you both! I've updated the todo list in the first comment.

@LecrisUT
Copy link
Collaborator

I've added 2 PRs for this release since it seems it is a major nuisance to the users

@lan496
Copy link
Member Author

lan496 commented Apr 10, 2024

@atztogo @LecrisUT Can I go on to releasing v2.4.0?

@LecrisUT
Copy link
Collaborator

On the feature side, all is good. Milestone wise there is #459 we can include, would be nice to have the full CI checks green again.

But don't forget to fix the changelog.md before tagging. There are duplicated Python interface and C interface sections that sneaked in some rebase

@lan496
Copy link
Member Author

lan496 commented Apr 10, 2024

@LecrisUT Thanks. Then, let's release the next version after merging #459.

@LecrisUT
Copy link
Collaborator

Need to investigate #469 and #468, depending on the result, it might be easier to post a bugfix. But until then, let's hold off creating the release manually

@chenrui333
Copy link

also need a github release cc @lan496

relates to Homebrew/homebrew-core#168648

@LecrisUT
Copy link
Collaborator

The release is in draft, but we are holding off until any PR or commit is added #468 (comment). The issue is about scikit-build/scikit-build-core#695, where the tar archive changes after a single commit is added due to %D in .git_archival.txt. I am investigating now if there is any fix for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants