-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Switch to importlib.resources
#308
Conversation
importlib.resources
importlib.resources
9acd14d
to
9a5e44b
Compare
importlib.resources
importlib.resources
9d1cc7d
to
0052f64
Compare
Scratch that it is still failing in pytest. Will investigate |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #308 +/- ##
========================================
Coverage 83.59% 83.59%
========================================
Files 24 24
Lines 8119 8119
Branches 1694 1687 -7
========================================
Hits 6787 6787
Misses 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a6ba623
to
011af03
Compare
OK, let's follow the order: #397 -> #335 -> #308 |
Ok, I've added the comments for the changelog for this trio and all is ready for final review |
d0ac510
to
fe76ba5
Compare
@LecrisUT Can you resolve conflicts? |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Ok, resolved, I'll let you check one more time the changes. |
In principle this should allow us to use
pip install -e .
and be able to debug more easily. But this requires upstreamscikit-build-core
to add an implementation:importlib.resources
in edittable installs scikit-build/scikit-build-core#399Depends on: #335