New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix CI builders #459
ci: Fix CI builders #459
Conversation
Interesting, only
Question is, do we want to include this one in 2.4 as well? This one has a minor fix to #233 on a7c63da, but otherwise it's completely neutral (can be added at any point). It would make PyPI have more MacOS wheels, so might be nice 😉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #459 +/- ##
========================================
Coverage 83.80% 83.80%
========================================
Files 25 25
Lines 8164 8164
Branches 1701 1701
========================================
Hits 6842 6842
Misses 1322 1322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1b77001
to
1608d97
Compare
f340578
to
e101d34
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
https://stackoverflow.com/q/45258925/22352077 Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
e101d34
to
ba621a8
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
All CI seem to be running without emulation Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
ba621a8
to
c726da4
Compare
macos-12
: ci: Fix CI builders #459 (comment)ci-build-wheel
to include M1 variants: Running all configurations at https://github.com/LecrisUT/spglib/actions/runs/8456467424Depends-on: #431
Closes #414