Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix CI builders #459

Merged
merged 7 commits into from Apr 10, 2024
Merged

ci: Fix CI builders #459

merged 7 commits into from Apr 10, 2024

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Mar 27, 2024

Depends-on: #431

Closes #414

@LecrisUT LecrisUT added the help wanted Need help from contributors label Mar 27, 2024
@LecrisUT LecrisUT added this to the 2.5 milestone Mar 27, 2024
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Mar 27, 2024

Interesting, only macos-12 a.k.a. macos-latest has the issue of test_with_broken_symmetry. For now, are we ok with just dropping that one since we would probably want to focus on macos-14 which has M1 chip. @atztogo @lan496

The other issues with the windows machines are fixable though since it seems they are only testing issues remaining, I'll try to handle those. Done.

Question is, do we want to include this one in 2.4 as well? This one has a minor fix to #233 on a7c63da, but otherwise it's completely neutral (can be added at any point). It would make PyPI have more MacOS wheels, so might be nice 😉

@LecrisUT LecrisUT removed the help wanted Need help from contributors label Mar 27, 2024
@LecrisUT LecrisUT requested review from atztogo and lan496 March 27, 2024 17:30
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (6e20e03) to head (c726da4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #459   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           25       25           
  Lines         8164     8164           
  Branches      1701     1701           
========================================
  Hits          6842     6842           
  Misses        1322     1322           
Flag Coverage Δ
c_api 74.71% <ø> (ø)
fortran_api 56.20% <ø> (ø)
python_api 80.04% <ø> (ø)
unit_tests 13.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT mentioned this pull request Apr 10, 2024
5 tasks
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
All CI seem to be running without emulation

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@lan496 lan496 merged commit 3785a2d into spglib:develop Apr 10, 2024
53 checks passed
@LecrisUT LecrisUT deleted the ci/fix-builders branch April 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

m1 mac on github actions
3 participants