-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic version #271
Dynamic version #271
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
57bf18a
to
3f420ba
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #271 +/- ##
===========================================
- Coverage 83.85% 83.71% -0.14%
===========================================
Files 24 24
Lines 8181 8205 +24
===========================================
+ Hits 6860 6869 +9
- Misses 1321 1336 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please call me again when ready for review 🙇 |
e4491e8
to
cbc8618
Compare
Waiting on a contribution: LecrisUT/CMakeExtraUtils#19, after which I will fix
|
a9dec84
to
d6e83b3
Compare
Ok, this is almost done. A few things to note:
|
6ffefbe
to
96daef7
Compare
In my environment,
gives |
The latter one is the expected behavior. I think it's because the |
a5b9aa0
to
15b500c
Compare
15b500c
to
364e2fe
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
364e2fe
to
c58aa8a
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de> Signed-off-by: Cristian Le <git@lecris.dev>
c58aa8a
to
4125010
Compare
Signed-off-by: Cristian Le <git@lecris.dev> Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
4125010
to
f2345a5
Compare
This generates the version from git tags or
.git_archival.txt
.DynamicVersion.cmake
here is from my project CMakeExtraUtils. I still need to add the testing there before I can publish it to Fedora, after that we can move the script out of here and get the latest version automatically.A few notes:
_version.py
has the__version__
as a string not tuple. That is the convention fromsetuptools_scm
, I don't know if it is the current standard. The tuple version is still available there, should we export that as well?-rc1
, so there is a difference with the displayed version. I can add anotherSpglib_FULL_VERSION
to export a version variable more completeversion_scheme
s to choose from that change the displayed version. Any preference on that?TODO:
scikit-build-core
is still experimental, wait until it is released to merge this_version.py
file is not automatically installed, need to fix this. Upstream issueMake sure the correct version is calculated in FedoraCheck that PyPI test still reports the correct versionCloses: #231, #380