Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor CMake project #397

Merged
merged 18 commits into from
Feb 13, 2024
Merged

feat: Refactor CMake project #397

merged 18 commits into from
Feb 13, 2024

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Jan 19, 2024 •
edited

Main things here:

  • Refactored apis and tests to be standalone sub-projects. This allows the subprojects to be built and run separately from pre-installed Spglib library
  • Run all tests within ctest (packaging and examples)
  • Have Fedora re-run all tests after installing the project

Depends on #362 (maybe also #271)
Closes #363, #353

@LecrisUT LecrisUT added the enhancement Significant ehancements label Jan 19, 2024
@LecrisUT
Copy link
Collaborator Author

Would be nice to have this one ready for the CECAM meeting so I can use it as an example project

@LecrisUT LecrisUT force-pushed the feat/cmake-organize branch 2 times, most recently from 2924ef6 to d8e00c7 Compare January 19, 2024 21:57
@LecrisUT LecrisUT self-assigned this Jan 19, 2024
@LecrisUT LecrisUT force-pushed the feat/cmake-organize branch 3 times, most recently from bc75a48 to 1664ec6 Compare January 19, 2024 23:00
LecrisUT
LecrisUT commented Jan 19, 2024
View reviewed changes
test/CMakeLists.txt Outdated Show resolved Hide resolved
@LecrisUT LecrisUT force-pushed the feat/cmake-organize branch 9 times, most recently from 9cbfe48 to 3408d60 Compare January 25, 2024 16:34
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cddbfae) 71.69% compared to head (922c607) 83.59%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #397       +/-   ##
============================================
+ Coverage    71.69%   83.59%   +11.89%     
============================================
  Files           51       24       -27     
  Lines         9483     8119     -1364     
  Branches      1754     1694       -60     
============================================
- Hits          6799     6787       -12     
+ Misses        2683     1332     -1351     
+ Partials         1        0        -1
Flag Coverage Δ
c_api 74.44% <ø> (-2.95%) ⬇️
fortran_api 56.18% <ø> (ø)
python_api 79.74% <ø> (ø)
unit_tests 13.52% <ø> (+12.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Jan 25, 2024
Closed
Merged
@LecrisUT LecrisUT added this to the 2.4 milestone Jan 25, 2024
@LecrisUT LecrisUT force-pushed the feat/cmake-organize branch 3 times, most recently from faae181 to 3b10b29 Compare January 25, 2024 18:00
@LecrisUT LecrisUT marked this pull request as ready for review January 25, 2024 18:07
@LecrisUT LecrisUT force-pushed the feat/cmake-organize branch 2 times, most recently from e3c555f to e27399e Compare January 25, 2024 19:12
@LecrisUT LecrisUT mentioned this pull request Feb 11, 2024
Open
@lan496 lan496 mentioned this pull request Feb 11, 2024
Merged
1 task
LecrisUT and others added 18 commits February 12, 2024 11:18
@LecrisUT
Bump minimum CMake version and set policy better
ad069a9 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Remove GNU extensions
2f65730 
We are not actually using any of these afaik

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Reshape banners
cc34d74 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Add message context
40cdcd6 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Wrong CMAKE_C_STANDARD comment
a3fa646 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Fix PackageCompsHelper
cbbbab2 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Migrate tests to standalone project
2951d8b 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Fix test-suite sub-project separation
85449a6 
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT
Simplify Fortran package test
5f012f4 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Run ctests in tmt
f26eac3 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Move examples to inside ctest
49e1aae 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Migrate Fortran api to sub-project
c7542f6 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Migrate Python api to sub-project
ae576c2 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Fix scikit-build configuration
43041bc 
Use `cmake.define` instead of `cmake.args`. The latter cannot be overriden via CLI

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Separate sanitizer tests
801abf0 
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
[Temp] workaround for missing pip in container
24463a3 
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT
test-suite documentation
6640a3c 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Document the main changes in spglib#397
922c607 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT assigned lan496 and unassigned LecrisUT Feb 12, 2024
@LecrisUT LecrisUT requested a review from lan496 February 12, 2024 10:24
@lan496
Copy link
Member

lan496 commented Feb 13, 2024 •
edited

testing-farm:fedora-39-aarch64 seems to be failed 🤔
https://github.com/spglib/spglib/pull/397/checks?check_run_id=21471792985

@LecrisUT
Copy link
Collaborator Author

Thnx, didn't notice it. It seemed it was just a network issue. I have just restarted it.

@lan496 lan496 merged commit 6f1aedc into spglib:develop Feb 13, 2024
39 of 42 checks passed
@LecrisUT LecrisUT deleted the feat/cmake-organize branch February 13, 2024 09:01
@LecrisUT LecrisUT mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lan496 lan496 lan496 approved these changes

Assignees

@lan496 lan496

Labels
enhancement Significant ehancements
Projects
Spglib developers' kanban
Status: ✅ Done
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

More CMake modernization CMake: Make subdirectories their own projects
2 participants
@LecrisUT @lan496