New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Reorganize CI #362
ci: Reorganize CI #362
Conversation
737a0ae
to
e7c6073
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #362 +/- ##
========================================
Coverage 83.85% 83.85%
========================================
Files 24 24
Lines 8181 8181
========================================
Hits 6860 6860
Misses 1321 1321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
![License Status][license-badge] | ||
![CMake Status][cmake-badge] | ||
[![Python Versions][python-version]][pypi-link] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python version badge will be fixed automatically in next pypi release
@LecrisUT I've received "Request to install Codecov in spglib". Is it needed for the codecov badge? I remember this project is already integrated with codecov. What is the difference? |
Can you get the badge api-token without installing codecov app? That's the main thing I'm trying with that. |
Do you need the badge api token as GitHub's Action secrets or raw string? |
Raw string, it's meant to be public and used in the README.md |
I see. Then, here it is.
|
e186729
to
b749111
Compare
5d81a44
to
67261a4
Compare
All badges except for Python version are working. Just 2 things for this PR:
|
Can you explain this a little more? Are these badges reflected only on main branch? |
I think the current emojis are nice! |
It's easiest with an example: |
toolchain: [ gcc, llvm, intel, windows, macos ] | ||
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12"] | ||
toolchain: [ gcc, llvm, intel ] | ||
python-version: [ "3.8", "3.x" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: "3.x" specifies the latest stable version.
https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#using-the-python-version-input
I see. Thanks, I've left a few comments. |
Is it included? |
Not yet, I will postpone it for after release #400 |
|
||
[ci-badge]: https://github.com/spglib/spglib/actions/workflows/ci.yaml/badge.svg?branch=develop&event=push | ||
[ci-link]: https://github.com/spglib/spglib/actions/workflows/ci.yaml?query=branch%3Adevelop+event%3Apush | ||
[cmake-badge]: https://img.shields.io/badge/CMake-3.15-blue?logo=data:image/svg%2bxml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGRhdGEtbmFtZT0iTGF5ZXIgMiIgdmlld0JveD0iMCAwIDU0NS41IDU0NS45Ij48cGF0aCBkPSJNNTQ2IDUzNCAyODIgOWwzOSA0MzQgMjI1IDkxeiIgZGF0YS1uYW1lPSJyZWQgcmlnaHQiIHN0eWxlPSJmaWxsOiNmMzI3MzU7c3Ryb2tlLXdpZHRoOjAiLz48cGF0aCBkPSJNNTI1IDU0NiAxNzAgNDAzIDEgNTQ2aDUyNHoiIGRhdGEtbmFtZT0iZ3JlZW4gYm90dG9tIiBzdHlsZT0ic3Ryb2tlLXdpZHRoOjA7ZmlsbDojM2VhZTJiIi8+PHBhdGggZD0iTTI2MyAwIDAgNTIybDI4OC0yNDRMMjYzIDB6IiBkYXRhLW5hbWU9ImJsdWUgbGVmdCIgc3R5bGU9ImZpbGw6IzAwNjhjNztzdHJva2Utd2lkdGg6MCIvPjxwYXRoIGQ9Im0yOTEgMjk5LTEwNSA4OSAxMTcgNDgtMTItMTM3eiIgZGF0YS1uYW1lPSJncmF5IGNlbnRlciIgc3R5bGU9ImZpbGw6I2RjZTNlYztzdHJva2Utd2lkdGg6MCIvPjwvc3ZnPg== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: We have to manually update the badge for the CMake minimum version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, specifically only the 3.15
text and only when we bump minimum version
@LecrisUT Can you address the branch conflicts? |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Concurrency should be checked only on the top-level CI/caller Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Make the CI report more navigable Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
- Reduce python tests: Only minimal + latest + future python version - Fix os toolchains Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Add a static-analysis checker. I was experimenting with. Postponed to Add a static-analysis checker #400sonarcloud
atCMake-Template
repo. I think it could be useful to include it as an intermediate toclang-tidy
. It is also polyglot, so it might pick up on more nieche problemsDepends on: #361 #358