Skip to content
This repository has been archived by the owner on Mar 10, 2021. It is now read-only.

Commit

Permalink
Raise timout to avoid problems.
Browse files Browse the repository at this point in the history
  • Loading branch information
@svenmueller
svenmueller committed Dec 16, 2014
1 parent d083f0c commit 83784af
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/spec/integration.spec.coffee
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ OrderStatusImport = require '../lib/orderstatusimport'
{SphereClient} = require 'sphere-node-sdk'

describe 'integration test', ->

jasmine.getEnv().defaultTimeoutInterval = 10000

beforeEach (done) ->

Expand Down

4 comments on commit 83784af

@emmenko
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use that, but specify the timeout in your test functions

beforeEach (done) ->
  # code
, 10000

afterEach (done) ->
  # code
, 10000

it 'should do something' (done) ->
  # code
, 10000

@svenmueller
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i did it by purpose this way to avoid repeating myself

@emmenko
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But ALL test functions have this timeout now, not sure you really want that. Usually it's only for integration tests for some particular use cases. Also, you may want to have 10s timeout for a test, but for another you need 20s.

@svenmueller
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, that makes sense. thx!

Please sign in to comment.