Adding json input/output support to openapi v2 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brockhaywood
force-pushed
the
json-schema
branch
2 times, most recently
from
8a1562e
to
198aa89
Compare
ikalnytskyi
approved these changes
Aug 10, 2019
There was a problem hiding this comment.
Hey @brockhaywood! Thank you for your patch and sorry for ignoring your PR for so long.
| @@ -65,9 +73,98 @@ def _httpresource(endpoint, method, properties): | |||
| for line in header['description'].splitlines(): | |||
| yield '{indent}{indent}{line}'.format(**locals()) | |||
|
|
|||
| for status, response in responses.items(): | |||
| if not is_2xx_response(status): | |||
There was a problem hiding this comment.
Why non-2xx are ignored? All other responses pretty often have the schema too, so why ignore them?
sphinxcontrib/openapi/openapi20.py
Outdated
| yield '{indent}:status {status}:'.format(**locals()) | ||
| for line in response['description'].splitlines(): | ||
| for line in response.get('description', '').splitlines(): |
There was a problem hiding this comment.
Why have you changed __getitem__ to .get here? According to OpenAPI v2 spec (link), description is required attribute of response object.
ikalnytskyi
force-pushed
the
json-schema
branch
from
90825e8
to
cba90d6
Compare
|
I applied some inline changes and did rebasing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrows heavily from #20