Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0] importlib.util.find_spec raises ValueError (it was not a case with imp.find_module) #96

Closed
amureki opened this issue Oct 19, 2020 · 1 comment

Comments

@amureki
Copy link

amureki commented Oct 19, 2020

Greetings!
Thakns for maintaining this package! ✨

While trying new version 6.0.0, we discovered the next issue:

Exception occurred:
  File "/opt/python/3.8.6/lib/python3.8/importlib/util.py", line 114, in find_spec
    raise ValueError('{}.__spec__ is None'.format(name))
ValueError: celery.__spec__ is None

I did try to dig a bit and discovered, that new importlib.find_spec raises ValueError in case the spec would be None or is not set. The change related to it was introduced in #73.

This behaviour differs from imp.find_module, where it was returning None or raising ImportError.

Seems like we need to update this bit in spelling library to cover new behaviour.

Cheers,
Rust

@amureki amureki changed the title importlib.util.find_spec raises ValueError (it was not a case with imp.find_module) [6.0.0] importlib.util.find_spec raises ValueError (it was not a case with imp.find_module) Oct 19, 2020
dhellmann added a commit that referenced this issue Oct 19, 2020
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
@dhellmann
Copy link
Member

The fix you've provided is included in release 7.0.0, so I'm going to close this issue. I think this is the same as #95, which I am leaving open until the reporters there can confirm that the fix also solves the problem for them.

Thanks again for finding and fixing the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants