Skip to content

Commit

Permalink
Stop enforcing that favicon's must be .ico
Browse files Browse the repository at this point in the history
Support for at least .png and .gif is now essentially universal, and
other formats (.jpg, .svg, etc.) are relatively widespread.

This was only a warning, but it's common to run sphinx with warnings
turned into errors, so it caused problems.
  • Loading branch information
njsmith committed May 7, 2017
1 parent 698d8d4 commit 07f1a6d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions sphinx/builders/html.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,6 @@ def prepare_writing(self, docnames):

favicon = self.config.html_favicon and \
path.basename(self.config.html_favicon) or ''
if favicon and os.path.splitext(favicon)[1] != '.ico':
self.warn('html_favicon is not an .ico file')

if not isinstance(self.config.html_use_opensearch, string_types):
self.warn('html_use_opensearch config value must now be a string')
Expand Down

0 comments on commit 07f1a6d

Please sign in to comment.