Skip to content

Commit

Permalink
Merge pull request #8412 from tk0miya/8164_autosummary_mock_imports_c…
Browse files Browse the repository at this point in the history
…auses_slowdown

Fix #8350: autosummary_mock_imports causes slow down builds
  • Loading branch information
tk0miya committed Nov 12, 2020
2 parents de2d2cc + 953a5ec commit 5cabdec
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES
Expand Up @@ -19,6 +19,7 @@ Bugs fixed
* #8372: autodoc: autoclass directive became slower than Sphinx-3.2
* #7727: autosummary: raise PycodeError when documenting python package
without __init__.py
* #8350: autosummary: autosummary_mock_imports causes slow down builds
* #8364: C, properly initialize attributes in empty symbols.
* #8399: i18n: Put system locale path after the paths specified by configuration

Expand Down
6 changes: 5 additions & 1 deletion sphinx/util/inspect.py
Expand Up @@ -122,7 +122,11 @@ def getargspec(func: Callable) -> Any:
def unwrap(obj: Any) -> Any:
"""Get an original object from wrapped object (wrapped functions)."""
try:
return inspect.unwrap(obj)
if hasattr(obj, '__sphinx_mock__'):
# Skip unwrapping mock object to avoid RecursionError
return obj
else:
return inspect.unwrap(obj)
except ValueError:
# might be a mock object
return obj
Expand Down

0 comments on commit 5cabdec

Please sign in to comment.