Fix #8534: autoattribute failed to document a commented attribute in …

…alias dervied class
sphinx-doc · Dec 16, 2020 · 966db73 · 966db73
1 parent 55c110f
commit 966db73
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/sphinx/ext/autodoc/__init__.py b/sphinx/ext/autodoc/__init__.py
@@ -2152,14 +2152,19 @@ def __init__(self):
 
     def get_attribute_comment(self, parent: Any) -> Optional[List[str]]:
         try:
-            analyzer = ModuleAnalyzer.for_module(self.modname)
-            analyzer.analyze()
+            for cls in inspect.getmro(parent):
+                try:
+                    module = safe_getattr(cls, '__module__')
+                    qualname = safe_getattr(cls, '__qualname__')
 
-            qualname = safe_getattr(parent, '__qualname__', None)
-            if qualname and self.objpath:
-                key = (qualname, self.objpath[-1])
-                if key in analyzer.attr_docs:
-                    return list(analyzer.attr_docs[key])
+                    analyzer = ModuleAnalyzer.for_module(module)
+                    analyzer.analyze()
+                    if qualname and self.objpath:
+                        key = (qualname, self.objpath[-1])
+                        if key in analyzer.attr_docs:
+                            return list(analyzer.attr_docs[key])
+                except (AttributeError, PycodeError):
+                    pass
         except (AttributeError, PycodeError):
             pass
 

diff --git a/tests/roots/test-ext-autodoc/target/typed_vars.py b/tests/roots/test-ext-autodoc/target/typed_vars.py
@@ -31,4 +31,4 @@ class Derived(Class):
     attr7: int
 
 
-Alias = Class
+Alias = Derived