New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Permalink to this {thing}" in tooltips, to "Link to this {thing}" #10049
Comments
If the maintainers are on board for this, I'm happy to file a PR for this! I lean toward not changing the method name |
Related to this - can we not add the link icon in the HTML but in the CSS instead? Because of this, an issue that arises is when I used say tocbot to create page's toc that sticks, it shows at the end of every title.... |
That is a separate concern. Please file a separate issue for it, since that is separate from (and independent of) changing the tooltips, which is what this issue is for. Also, Sphinx has |
I agree with this proposal: the current wording may indeed lead to false expectations and eventual disappointment. I would however note that there's also the config option The question then is what to call this thing? An option named simply If not that, then maybe "item links" would be more comprehensive. But it also quite generic and as such fairly difficult to guess. Or something else entirely. But the config option should not be forgotten. Unfortunately, it was renamed not that long ago, known as |
Fixed in 7e9a206 A |
Describe the bug
According to Wikipedia:
Sphinx uses the word "Permalink" in the tooltips for various things, such as headings/definitions/images/code etc. This is not configurable by the user and is not ideal; since not all of the documentation sites have similar policies on how link rot/renaming etc would be handled. This is especially problematic since a lot of Sphinx-based documentation is on ReadTheDocs, which by default has pages like
pip.readthedocs.io/en/latest/
which are decidedly not going to present permalinks (unless the documentation author is really careful; which... yea, not guarenteed).It would be better to change "Permalink" to "Link", avoiding the concern of whether a link is going to be long-lived or not entirely. Plus, it's more "generally correct" -- a permalink is still a link. :)
How to Reproduce
Build any Sphinx documentation, containing one or more headings (eg: https://pradyunsg.me/furo/kitchen-sink/demo/). When hovering over the Sphinx-injected "headerlink", notice that it says "Permalink to this heading".
Expected behavior
Change to "Link to this heading".
Your project
https://github.com/pradyunsg/furo
Screenshots
OS
N/A
Python version
N/A
Sphinx version
4.x
Sphinx extensions
No response
Extra tools
No response
Additional context
Excluding the locale files, there's quite a few instances that would need updating:
If this ends up being OK to do, we should change this no sooner than Sphinx 5.0 (similar to #10041).
The text was updated successfully, but these errors were encountered: