Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to install due to docutils latest version contains string #3821

Closed
kfirilani opened this issue May 28, 2017 · 8 comments
Closed

failed to install due to docutils latest version contains string #3821

kfirilani opened this issue May 28, 2017 · 8 comments
Labels
Milestone

Comments

@kfirilani
Copy link

while trying to upgrade sphinx, it tries to update docutils.
docutils latest package version is 0.14rc1
while parsing the version, it fails due to parse error for int()

File "/Users/ci/workspace/wrk_automation_utils_mac_debug/.eggs/Sphinx-1.3.1-py2.7.egg/sphinx/util/compat.py", line 17, in
docutils_version = tuple(int(x) for x in _du_version.split('.')[:2])
ValueError: invalid literal for int() with base 10: '14rc1'

Can you fix that it wont fail in case of dependency version parsing error?

@tk0miya
Copy link
Member

tk0miya commented May 28, 2017

Same as #3814. It is fixed newest release: 1.6.2.
Please upgrade to newest one.

Thanks,

@jfbu
Copy link
Contributor

jfbu commented May 28, 2017

@tk0miya unfortunately this is not duplicate but other one at sphinx.util.compat

@tk0miya
Copy link
Member

tk0miya commented May 28, 2017

oh, sorry. reopened.

@tk0miya
Copy link
Member

tk0miya commented May 28, 2017

I will take a look tomorrow (in Japan, it's night 🌃 now)

@jfbu
Copy link
Contributor

jfbu commented May 28, 2017

it was a hectic and very productive day thanks to you...

unfortunately we overlooked this one in time for 1.6.2, sorry because I should have looked more systematically at the time of my initial report for other such situations in Sphinx code base relative to Docutils version string

@jfbu
Copy link
Contributor

jfbu commented May 28, 2017

@kfirilani actually I was too pessimistic. The sphinx.util.compat module is not imported by core Sphinx anywhere anymore afaict. It may be imported by extensions. Can you try upgrading to Sphinx 1.6.2 ?

@tk0miya
Copy link
Member

tk0miya commented May 29, 2017

Good morning, all.
I checked with 1.6.2, and it did not reproduced.

The sphinx.util.compat module is not imported by core Sphinx anywhere anymore afaict.

Yes, the module is deprecated now. So it does not prevent the behavior of sphinx-core.

@tk0miya
Copy link
Member

tk0miya commented May 29, 2017

About sphinx.util.compat, fixed at ff1adc7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants