Include the exception when logging PO/MO file read/write #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this there is no way to troubleshoot why (read/write)_po fails.
ideasman42
changed the title
tk0miya
requested changes
Oct 13, 2017
sphinx/util/i18n.py
Outdated
| @@ -67,15 +67,15 @@ def write_mo(self, locale): | |||
| with io.open(self.po_path, 'rt', encoding=self.charset) as file_po: | |||
| try: | |||
| po = read_po(file_po, locale) | |||
| except Exception: | |||
| logger.warning('reading error: %s', self.po_path) | |||
| except Exception as ex: | |||
There was a problem hiding this comment.
In this project, we usually use exc or err for variable name. Could you rename this to exc please?
|
Update with requested changes |
tk0miya
approved these changes
Oct 13, 2017
|
Thank you for contribution and your quick response! |
tk0miya
added a commit
that referenced
this pull request
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this there is no way to troubleshoot why (read/write)_po fails.
Our project ran into an error where all translations fail, there was no simple way to find out why, without local edits to
i18n.pySubject: log exception messages
Feature or Bugfix
Purpose
Detail
None.