Missing remote image warnings not showing up when building HTML

[barbara-sfx]

Problem

make clean latexpdf or make clean latex gives warning messages about missing images in the step "Resolving references", but make clean html does not. I don't even see a Resolving References step when doing make clean html

Procedure to reproduce the problem

make clean latex shows warnings on missing remote images, e.g.

WARNING: Could not fetch remote image: https://raw.githubusercontent.com/.../dashboard_redshift.png [404]

but make clean html does not. So my live site now shows a number of broken images.

Error logs / results

https://docs.signalfx.com/en/latest/integrations/integrations-reference/integrations.amazon.redshift.html

Expected results

Show warnings when building HTML

Reproducible project / your project

Environment info

• OS: Mac 10.13.4
• Python version: 2.7
• Sphinx version: 1.7.5
• <Extra tools e.g.: Browser, tex or something else>

[tk0miya]

Sure. HTML builder does not fetch remote images. So the warnings are never shown.
But it would be nice if we can check its validity by linkcheck builder.

[barbara-sfx]

I have seen these messages in the past. So the warnings must have been removed in a sphinx update. If I have time, I can try to revert to an earlier version (although the last time I tried that I kind of screwed up my system due to my general unfamiliarity with some system activities). The last one I used before 1.7.5 was (I believe) 1.6.4.

…

-- Barbara

On Jul 20, 2018, at 11:26 PM, Takeshi KOMIYA ***@***.*** ***@***.***>> wrote: Sure. HTML builder does not fetch remote images. So the warnings are never shown. But it would be nice if we can check its validity by linkcheck builder. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5196 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQ457jVev1NLKnH6M0IcBa53L9yHf3aPks5uIsmKgaJpZM4VZPve>. <https://assets-cdn.github.com/images/email/message_cards/header.png> <https://assets-cdn.github.com/images/email/message_cards/avatar.png> <https://github.com/sphinx-doc/sphinx> <#5196 (comment)> <http://schema.org/> <#5196 (comment)> <#5196 (comment)> <https://github.com/> <http://schema.org/extensions> <https://assets-cdn.github.com/images/email/message_cards/avatar.png> <https://api.github.com/> <https://api.github.com/> <#5196 (comment)> <https://api.github.com/>

[tk0miya]

I guess you saw the warnings on resizing image. Actually, HTML builders emits them only on resizing.

[barbara-sfx]

What do you mean by resizing image? These graphics all take the following format:

in text:

|image1|

At the bottom of the file:

.. |image1| image:: https://raw.githubusercontent.com/.../dashboard_redshift.png

Image size is never addressed in the docs.

[tk0miya]

What I meant is giving resizing option to image directive like this:

.. image:: picture.png
   :width: 50%

AFAIK old sphinx did not emit warnings for subsutituion (cf. |image1|).
Please let me know if you can reproduce it.

If this is regression, I will fix this soon. If not, I will work for this after 1.8 release.

[barbara-sfx]

As my sample showed, I am not using the ..image:: directive

If time allows, I'll see if I can figure out which version gave the errors. It might have been as far back as 1.4.

[barbara-sfx]

Oh actually, they have fixed the missing images problem, so I would have to break something to test again. But I am 100% certain it worked before. I was working on a pre-release set of docs which pointed to images in a dev github repo that was still under development and did not yet contain the images the docs linked to. I just had to ignore all the warnings for a while during development. So I do think it is a regression.

[tk0miya]

Until somebody let me know reproducible information, I will keep this as "proposal", not "regression".
Thanks,

[tk0miya]

Fixed by #6022.
Thank you for proposal.