New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The addition of partial search support in the HTML builds has a logic error #6824
Labels
Comments
@TimKam Could you check this please? |
Thanks for reporting. I will check. |
TimKam
added a commit
that referenced
this issue
Nov 17, 2019
Prevent duplicate additions of terms to a file in ``fileMap``
TimKam
added a commit
that referenced
this issue
Nov 17, 2019
Merged
TimKam
added a commit
that referenced
this issue
Nov 20, 2019
Prevent duplicate additions of terms to a file in ``fileMap``
TimKam
added a commit
that referenced
this issue
Nov 20, 2019
TimKam
added a commit
that referenced
this issue
Nov 20, 2019
* #6824: Fix search logic (front end) Prevent duplicate additions of terms to a file in ``fileMap``, document search fix in change log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
In certain edge cases, the 'Search module' in searchtools.js will exit the 'performTermsSearch' method early (in the 'check if all requirements are matched' section), resulting in no results being returned, when there should be results returned.
To Reproduce
Steps to reproduce the behavior:
There may be other ways that this error manifest, but I'll give the simplest steps that I'm aware of.
Expected behavior
A clear and concise description of what you expected to happen.
The 'performTermsSearch' method was created before 'support for partial matching' was added earlier this year. The partial matching allows for a condition where a partial match can exist in the 'titleterms' and a full match can exist in the 'terms'. Whereas the performTermsSearch method is coded expecting for this condition of matches in both titleterms and terms to never be able to occur.
Additional context
I think the fix is within these two code blocks.
The text was updated successfully, but these errors were encountered: