Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "headline" to "heading" #10048

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Change "headline" to "heading" #10048

merged 1 commit into from
Jan 2, 2022

Conversation

pradyunsg
Copy link
Contributor

Feature or Bugfix

  • Bugfix?

Relates

Closes #10041, which has the relevant discussion and context.

@pradyunsg
Change "Permalink to this {headline -> heading}"
bc63562 
"heading" is a better word to use in this tooltip, since it better
matches the use case.
@pradyunsg
Copy link
Contributor Author 

mypy run-test: commands[0] | mypy sphinx/
sphinx/directives/patches.py: note: In member "run" of class "Meta":
sphinx/directives/patches.py:86:16: error: Incompatible return value type (got "Sequence[Node]", expected "List[Node]")
Found 1 error in 1 file (checked 177 source files)

The mypy failure seems unrelated.

@tk0miya tk0miya added builder:html type:proposal a feature suggestion labels Jan 2, 2022
@tk0miya tk0miya added this to the 5.0.0 milestone Jan 2, 2022
@tk0miya tk0miya merged commit 3cb680a into sphinx-doc:master Jan 2, 2022
@tk0miya
Copy link
Member

tk0miya commented Jan 2, 2022

Thanks!

@pradyunsg pradyunsg deleted the change-heading-anchor-tooltip branch January 2, 2022 16:23
akdor1154 pushed a commit to akdor1154/sphinx that referenced this pull request Jan 7, 2022
sphinx-doc#10048 - add failing test
0560801
akdor1154 pushed a commit to akdor1154/sphinx that referenced this pull request Jan 7, 2022
sphinx-doc#10048 - add failing test
1f01719
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
builder:html type:proposal a feature suggestion
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pradyunsg @tk0miya