Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searchtools: don't assume that all themes define some elements #10153

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Searchtools: don't assume that all themes define some elements #10153

merged 2 commits into from
Apr 4, 2022

Commits on Feb 1, 2022

  1. Searchtools: don't assume that all themes define some elements 

    When retrieving a non-existent element, jQuery would still return an
object (kind of empty one, so method calls won't raise a null
exception), but now `getElementById` will return null and raise an
exception when trying to call a method on that value.

This mainly affects the rtd theme,
which completely overrides the search page
https://github.com/readthedocs/sphinx_rtd_theme/blob/d64dadf1ceec4f9ff6c1ca2d3ea4c3d0fdb0e8d2/sphinx_rtd_theme/search.html
    @stsewd
    stsewd committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    6605bfb View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Update sphinx/themes/basic/static/searchtools.js 

    Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
    @stsewd @AA-Turner
    stsewd and AA-Turner committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a45e4d4 View commit details
    Browse the repository at this point in the history