Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove module docstring titles #10212

Merged
merged 9 commits into from
Mar 13, 2022

Conversation

AA-Turner
Copy link
Member

Closes #10160

Alternative to #10208

@tk0miya -- I had been working on an expanded version of your PR, you beat me to it!

Over and above #10208, this conforms module docstrings to PEP 257 by moving the summary line next to the opening quotes, dedents the text, ensures summary lines are less than 80 characters, and also removes redundant copyright & licencing information (see this post for more infomation on why this is OK.)

I did keep the copyright notices where a different licence has been used, though.

A

@AA-Turner AA-Turner force-pushed the remove-module-docstring-titles branch from 2c06c32 to f05d455 Compare February 20, 2022 03:32
@tk0miya tk0miya added this to the 4.5.0 milestone Mar 2, 2022
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

sphinx/ext/napoleon/docstring.py Outdated Show resolved Hide resolved
sphinx/ext/napoleon/iterators.py Outdated Show resolved Hide resolved
tests/test_ext_napoleon.py Outdated Show resolved Hide resolved
tests/test_ext_napoleon_docstring.py Outdated Show resolved Hide resolved
tests/test_ext_napoleon_iterators.py Outdated Show resolved Hide resolved
tests/test_intl.py Show resolved Hide resolved
@AA-Turner
Copy link
Member Author

@tk0miya I've fixed all the ones you raised.

A

@AA-Turner AA-Turner force-pushed the remove-module-docstring-titles branch from f59fc41 to f05a068 Compare March 7, 2022 15:28
@tk0miya
Copy link
Member

tk0miya commented Mar 13, 2022

Thank you for your update. Merging now. Good work!

@tk0miya tk0miya merged commit b12b39d into sphinx-doc:4.x Mar 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
@AA-Turner AA-Turner deleted the remove-module-docstring-titles branch May 2, 2022 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow PEP 257 docstring conventions
2 participants