Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated setup.py build_sphinx #10352

Merged
merged 2 commits into from Apr 17, 2022

Conversation

AA-Turner
Copy link
Member

Refactor tox.ini to call sphinx -M html directly.

A

Feature or Bugfix

  • Refactoring

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


with open(changelog_path) as f:
with open(changelog_path, encoding="utf-8") as f:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is a bug fix of "our document". So we don't need to mention it on CHANGES.

@tk0miya tk0miya added this to the 5.0.0 milestone Apr 17, 2022
@tk0miya tk0miya merged commit eff6930 into sphinx-doc:5.x Apr 17, 2022
@tk0miya
Copy link
Member

tk0miya commented Apr 17, 2022

Thanks as always!

@AA-Turner AA-Turner deleted the sphinx-docs-build branch May 2, 2022 17:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants