fix #10363 make sphinxmaketitle ruler use \linewidth not \textwidth #10365
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, but you have used the wrong issue number in the commit message and title. (Not sure if the CHANGES file is auto-generated or not, but same there.) |
|
We have a plan to release 5.0 soon. So it's better to merge this into the 5.x branch. Could you rebase this, please? |
|
Thanks! I will address the issues raised by @oscargus by force-pushing to your branch to rebase on 5.0.0 for merge, hope you don't mind. |
Closed
jfbu
force-pushed
the
10363-sphinxmaketitle-should-use-linewidth-fix
branch
from
35a6d11
to
6487529
Compare
jfbu
changed the title
|
Merged ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: use \linewidth not \textwidth for sphinxmaketitle ruler
Feature or Bugfix
Purpose
sphinxmaketitle should use \linewidth not \textwidth for his ruler
Relates