Update requests links
#10482
Closed
Update requests links
#10482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
reviewed
May 28, 2022
| @@ -109,7 +109,6 @@ | |||
|
|
|||
| intersphinx_mapping = { | |||
| 'python': ('https://docs.python.org/3/', None), | |||
| 'requests': ('https://docs.python-requests.org/en/latest/', None), | |||
There was a problem hiding this comment.
As I made the authentication link inline, and nothing else used interphinx requests.
A
There was a problem hiding this comment.
I feel it's better to update this URL by new one (refs: #10484). What do you think?
There was a problem hiding this comment.
I don't mind either way, just important for CI to be fixed.
A
There was a problem hiding this comment.
Thanks, I'd like to choose #10484.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI due to the
python-requestsdomain no longer working.@tk0miya please can this go into 5.0.0 to fix CI / for correct docs?
Feature or Bugfix
A