Fix #10594: HTML: field term colons are doubled if using Docutils 0.18+

[jfbu]

Relates

• Fix double brackets #10523

The Docutils commit responsible for the change at 0.18 is rev8734

Nota bene:

• our test suite did not detect the added <span class="colon">:</span> at Docutils 0.18. As I am not competent enough to add a test conditional on Docutils version I did not (remember I am only LaTeX guru here).
• I guess the docinfo class for <dl> is not involved at Sphinx level

[AA-Turner]

Thanks @jfbu! I suggested a couple of changes.

Testing HTML output is a much bigger challenge in general, as it pretty much needs to be a visual comparison -- layered CSS files etc. can affect output with identical HTML content.

A

[jfbu]

Thanks @jfbu! I suggested a couple of changes.

ok thanks, applied.

I see now that you had been defining and using docutils_version_info elsewhere in basic.css_t already. And that we require Docutils >= 0.14 which added docutils.__version_info__.

About the change to CHANGES, I had noticed you used HTML Theme however I found this terminology a bit unclear.
Your suggestion applied anyhow.

Testing HTML output is a much bigger challenge in general, as it pretty much needs to be a visual comparison -- layered CSS files etc. can affect output with identical HTML content.

Yes, understood, however I was surprised that we (I initially wrote "you" by mistake ;-) ) did not have a check which would have signaled html output (I mean the html files, not how they are rendered, and not even the CSS files) got modified by the upstream Docutils 0.18 changes.

Visual comparison is imho simply not feasible and will always let things pass through. I apply it from time to time on our own docs sphinx.pdf but very superficially, trying more to detect changes in LaTeX compilation log behavior.

[AA-Turner]

About the change to CHANGES, I had noticed you used HTML Theme however I found this terminology a bit unclear. Your suggestion applied anyhow.

I just use it as it seems to be the precedent for CSS changes etc.

Yes, understood, however I was surprised that we (I initially wrote "you" by mistake ;-) ) did not have a check which would have signaled html output (I mean the html files, not how they are rendered, and not even the CSS files) got modified by the upstream Docutils 0.18 changes.

Hmm, perhaps we can add such a thing. It is difficult to construct a short test file that hits all the various permutations of reST syntax, though.

A