[C++] Ensure consistent non-specialization template argument representation, rebased and updated #10729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobandersen
force-pushed
the
cpp-template-args-non-specialized
branch
2 times, most recently
from
df8d5b0
to
9ac4df0
Compare
…tation Previously, in certain cases the template arguments of non-specializations were retained, leading to incorrect merging of symbols.
Specifically 'template<int (X::*)(bool)...>'
jakobandersen
force-pushed
the
cpp-template-args-non-specialized
branch
from
9ac4df0
to
44ecc13
Compare
jakobandersen
force-pushed
the
cpp-template-args-non-specialized
branch
from
44ecc13
to
f5c21a1
Compare
|
Thanks! |
|
Per the TODO entry in my original PR you added support for parsing:
However, that does not appear to be valid C++ syntax. I believe the correct syntax is:
|
|
It depends on which location. In the test it was as a non-type template parameter: struct X {};
template<int (X::*)(bool)...>
void f() {}i.e., a pack of member function pointers. The addition was to make that parse in Sphinx. |
|
Ah, thanks for the clarification. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated version of #10257.
In addition the parameter pack parsing is fixed for one of the noted cases, while the other case is not valid C++ code anyway.