Prevent warning filters from being discarded #11024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a context manager to ignore ImportWarning during module imports also prevents libraries setting warnings filters (such as NumPy) from being persistent, since the filters they set are discarded when exiting the context manager. Closes sphinx-doc#11022
teobouvard
changed the title
# Conflicts: # sphinx/ext/autodoc/importer.py
|
Thanks @teobouvard! A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a context manager to ignore
ImportWarningduring module imports also prevents libraries setting warning filters (such as NumPy) from being persistent, since the filters they set are discarded when exiting the context manager.I might be missing something, but it seems the usage of this context manager to ignore such warnings is redundant with the default warning filters installed by Python.
Closes #11022