Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate the colour of previously-visited hyperlinks #11390

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Differentiate the colour of previously-visited hyperlinks #11390

merged 1 commit into from
Jul 27, 2023

Conversation

kaycebasques
Copy link
Contributor

@kaycebasques kaycebasques commented May 1, 2023

Subject: Make visited links default color different

Feature or Bugfix

  • Feature

Purpose

  • Make it easier to tell which pages you have visited

Detail

Relates

Screenshots

All are ordered before and then after.

agogo

agogo-before

agogo-after

basic

basic-before

basic-after

bizstyle

bizstyle-before

bizstyle-after

classic

classic-before

classic-after

default

default-before

default-after

epub

epub-before

epub-after

haiku

haiku-before

haiku-after

nature

nature-before

nature-after

nonav

nonav-before

nonav-after

pyramid

pyramid-before

pyramid-after

scrolls

scrolls-before

scrolls-after

sphinxdoc

sphinxdoc-before

sphinxdoc-after

traditional

traditional-before

traditional-after

@kaycebasques
Copy link
Contributor Author

I can't tell if that CI / Docutils HEAD (pull_request) is related to my changes or is just flaky: https://github.com/sphinx-doc/sphinx/actions/runs/4855074164/jobs/8653200660?pr=11390

@webknjaz
Copy link
Contributor

webknjaz commented May 1, 2023

@kaycebasques that looks flaky. Try retriggering the CI by closing and reopening this PR...

@kaycebasques kaycebasques changed the title Fix #1708 (make visited links default color different) Make visited links colors different May 2, 2023
@kaycebasques kaycebasques reopened this May 2, 2023
@kaycebasques
Copy link
Contributor Author

I'll try one more time but it seems like there may actually be something failing here...

@astrojuanlu
Copy link
Contributor

Hey @AA-Turner @tk0miya, @kaycebasques pinged me in private about this PR. It fixes an 8 years old issue and looks good to be merged.

But more broadly, I'm wondering how you folks are doing in terms of workload, and whether you'd be open to have a conversation about governance. Looks like lots of folks from the Write the Docs community want to contribute to Sphinx and help, and it's not clear what's the best way to do so. I don't want to have that discussion here - we can open a separate issue about that.

@AA-Turner AA-Turner changed the title Make visited links colors different Differentiate the colour of previously-visited hyperlinks Jul 27, 2023
@AA-Turner AA-Turner merged commit 23c7fdd into sphinx-doc:master Jul 27, 2023
66 of 69 checks passed
@AA-Turner
Copy link
Member

Thanks @kaycebasques!

@AA-Turner AA-Turner added this to the 7.2.0 milestone Aug 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make visited links default color different
4 participants