Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning on Python 3.12 about deprecated utcfromtimestamp #11468

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

henryiii
Copy link
Contributor

See https://docs.python.org/3.12/library/datetime.html#datetime.datetime.utcfromtimestamp

Subject: fix a warning when running on Python 3.12's betas.

Feature or Bugfix

  • Bugfix

Purpose

  • fix a warning when running on Python 3.12's betas.

Should be backward compatible (3.12's suggestion to use datetime.UTC was added in 3.11, so isn't that helpful - but that's just an alias for datetime.timezone.utc)

@henryiii
Copy link
Contributor Author

Ahh, this used from datetime import datetime. 😮‍💨

sphinx/builders/gettext.py Outdated Show resolved Hide resolved
sphinx/builders/gettext.py Outdated Show resolved Hide resolved
@AA-Turner AA-Turner merged commit cc78e2a into sphinx-doc:master Jul 20, 2023
27 checks passed
@AA-Turner
Copy link
Member

Thanks @henryiii!

A

@henryiii henryiii deleted the patch-1 branch July 20, 2023 17:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants