Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor suggested edits following review of pull request #11499 #11501

Merged

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Purpose

Detail

  • Omit a variable that is unused aside from a return statement on the subsequent line.
  • Extract a variable for readability, and to reduce the code complexity of a code line.

Relates

cc @AA-Turner

@AA-Turner AA-Turner merged commit 71db08c into sphinx-doc:master Jul 23, 2023
25 of 27 checks passed
@AA-Turner
Copy link
Member

Thanks!

@jayaddison jayaddison deleted the pr-11499/code-review-suggestions branch July 23, 2023 14:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants