Fix typos newly found by codespell #11735
Conversation
DimitriPapadopoulos
force-pushed
the
codespell
branch
4 times, most recently
from
90da3e4
to
8aed5e5
Compare
DimitriPapadopoulos
force-pushed
the
codespell
branch
from
8aed5e5
to
cdcdfda
Compare
There was a problem hiding this comment.
All of the .po files can be excluded from the spelling checker, they're automatically updated from the source.
There was a problem hiding this comment.
That's what I thought, but I had been told otherwise in #11735 (comment).
Any way, these updates are in a separate commit, they would be easy to discard.
There was a problem hiding this comment.
If we change a localized string, I think what is autogenerated is an empty translation, hence we probably need to manually update translations in this case but I may be wrong.
sphinx/writers/text.py
Outdated
| @@ -156,7 +156,7 @@ def cell_width(self, cell: Cell, source: list[int]) -> int: | |||
| This takes into account cells spanning multiple columns. | |||
| """ | |||
| if cell.row is None or cell.col is None: | |||
| msg = 'Cell co-ordinates have not been set' | |||
| msg = 'Cell coordinates have not been set' | |||
There was a problem hiding this comment.
Both co-ordinate and coordinate are fine, especially in British English according to dictionaries. However, the Google Ngram Viewer shows coordinate in wider use, including in the British English corpus strangely enough.
It's up to you, but what's wrong with following common use when targetting a large and international audience?
There was a problem hiding this comment.
Even though co-ordinate is fine, I personally prefer one without "-". Also it removes one character from the code base so it's technically an optimization!
There was a problem hiding this comment.
How about a compromise and use "coördinates" like the New Yorker! 🙃
https://www.newyorker.com/culture/culture-desk/the-curse-of-the-diaeresis
Subject: fix typos
Feature or Bugfix