Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versionremoved directive #11905

Merged
merged 4 commits into from
Jan 21, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/usage/builders/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -453,9 +453,9 @@ name is ``rinoh``. Refer to the `rinohtype manual`_ for details.
.. class:: ChangesBuilder

This builder produces an HTML overview of all :rst:dir:`versionadded`,
:rst:dir:`versionchanged` and :rst:dir:`deprecated` directives for the
current :confval:`version`. This is useful to generate a ChangeLog file, for
example.
:rst:dir:`versionchanged`, :rst:dir:`deprecated` and :rst:dir:`versionremoved`
directives for the current :confval:`version`. This is useful to generate a
ChangeLog file, for example.
hugovk marked this conversation as resolved.
Show resolved Hide resolved

.. autoattribute:: name

Expand Down
10 changes: 10 additions & 0 deletions doc/usage/restructuredtext/directives.rst
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,16 @@ units as well as normal text.
.. deprecated:: 3.1
Use :func:`spam` instead.

.. rst:directive:: .. versionremoved:: version

Similar to :rst:dir:`versionremoved`, but describes when and what removed the
hugovk marked this conversation as resolved.
Show resolved Hide resolved
described feature to the library or C API. Example::
hugovk marked this conversation as resolved.
Show resolved Hide resolved

.. versionremoved:: 4.0
Use :func:`spam` instead.
hugovk marked this conversation as resolved.
Show resolved Hide resolved

.. versionadded:: 7.3

.. rst:directive:: seealso

Many sections include a list of references to module documentation or
Expand Down
4 changes: 2 additions & 2 deletions sphinx/addnodes.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,8 @@ class desc_sig_literal_char(desc_sig_element, _sig_element=True):
class versionmodified(nodes.Admonition, nodes.TextElement):
"""Node for version change entries.

Currently used for "versionadded", "versionchanged" and "deprecated"
directives.
Currently used for "versionadded", "versionchanged", "deprecated"
and "versionremoved" directives.
"""


Expand Down
9 changes: 6 additions & 3 deletions sphinx/builders/changes.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

class ChangesBuilder(Builder):
"""
Write a summary with all versionadded/changed directives.
Write a summary with all versionadded/changed/deprecated/removed directives.
"""

name = 'changes'
Expand All @@ -43,6 +43,7 @@ def get_outdated_docs(self) -> str:
'versionadded': 'added',
'versionchanged': 'changed',
'deprecated': 'deprecated',
'versionremoved': 'removed',
}

def write(self, *ignored: Any) -> None:
Expand Down Expand Up @@ -106,7 +107,9 @@ def write(self, *ignored: Any) -> None:

hltext = ['.. versionadded:: %s' % version,
'.. versionchanged:: %s' % version,
'.. deprecated:: %s' % version]
'.. deprecated:: %s' % version,
'.. versionremoved:: %s' % version,
]

def hl(no: int, line: str) -> str:
line = '<a name="L%s"> </a>' % no + html.escape(line)
Expand Down Expand Up @@ -143,7 +146,7 @@ def hl(no: int, line: str) -> str:

def hl(self, text: str, version: str) -> str:
text = html.escape(text)
for directive in ('versionchanged', 'versionadded', 'deprecated'):
for directive in ('versionchanged', 'versionadded', 'deprecated', 'versionremoved'):
text = text.replace(f'.. {directive}:: {version}',
f'<b>.. {directive}:: {version}</b>')
return text
Expand Down
3 changes: 3 additions & 0 deletions sphinx/domains/changeset.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
'versionadded': _('New in version %s'),
'versionchanged': _('Changed in version %s'),
'deprecated': _('Deprecated since version %s'),
'versionremoved': _('Removed in version %s'),
}

versionlabel_classes = {
'versionadded': 'added',
'versionchanged': 'changed',
'deprecated': 'deprecated',
'versionremoved': 'removed',
}


Expand Down Expand Up @@ -153,6 +155,7 @@ def setup(app: Sphinx) -> dict[str, Any]:
app.add_directive('deprecated', VersionChange)
app.add_directive('versionadded', VersionChange)
app.add_directive('versionchanged', VersionChange)
app.add_directive('versionremoved', VersionChange)

return {
'version': 'builtin',
Expand Down
3 changes: 3 additions & 0 deletions tests/roots/test-changes/base.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ Version markup
.. deprecated:: 0.6
Boring stuff.

.. versionremoved:: 0.6
Goodbye boring stuff.

.. versionadded:: 1.2

First paragraph of versionadded.
Expand Down
3 changes: 3 additions & 0 deletions tests/roots/test-intl/versionchange.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ i18n with versionchange
.. versionchanged:: 1.0

This is the *first* paragraph of versionchanged.

.. versionremoved:: 1.0
This is the *first* paragraph of versionremoved.
hugovk marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions tests/roots/test-intl/xx/LC_MESSAGES/versionchange.po
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,5 @@ msgstr "THIS IS THE *FIRST* PARAGRAPH OF VERSIONADDED."
msgid "This is the *first* paragraph of versionchanged."
msgstr "THIS IS THE *FIRST* PARAGRAPH OF VERSIONCHANGED."

msgid "This is the *first* paragraph of versionremoved."
msgstr "THIS IS THE *FIRST* PARAGRAPH OF VERSIONREMOVED."
3 changes: 3 additions & 0 deletions tests/roots/test-root/markup.txt
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ Version markup
.. deprecated:: 0.6
Boring stuff.

.. versionremoved:: 0.6
Goodbye boring stuff.

.. versionadded:: 1.2

First paragraph of versionadded.
Expand Down
1 change: 1 addition & 0 deletions tests/test_builders/test_build_html_5_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ def checker(nodes):
tail_check('First paragraph of versionchanged')),
('markup.html', ".//div[@class='versionchanged']/p",
'Second paragraph of versionchanged'),
('markup.html', ".//div[@class='versionremoved']/p/span", 'Removed in version 0.6: '),
# footnote reference
('markup.html', ".//a[@class='footnote-reference brackets']", r'1'),
# created by reference lookup
Expand Down
6 changes: 6 additions & 0 deletions tests/test_intl/test_intl.py
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,12 @@ def get_content(result, name):
matched_content = get_content(result, "versionchanged")
assert expect3 == matched_content

expect4 = (
"""<p><span class="versionmodified removed">Removed in version 1.0: </span>"""
"""THIS IS THE <em>FIRST</em> PARAGRAPH OF VERSIONREMOVED.</p>\n""")
matched_content = get_content(result, "versionremoved")
assert expect4 == matched_content


@sphinx_intl
@pytest.mark.sphinx('html')
Expand Down