Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] linkcheck: add test coverage for behaviour of a locally-existing file. #12128

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Feature

Purpose

  • Adds test coverage to demonstrate how the linkcheck builder currently behaves with regard to local files that exist and are referenced in documentation.

Detail

  • Assert that the conf.py file from the test-linkcheck testroot is considered a working link.

Relates

tests/test_builders/test_build_linkcheck.py Outdated Show resolved Hide resolved
jayaddison and others added 2 commits March 18, 2024 14:05
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz merged commit 7894b5a into sphinx-doc:master Mar 18, 2024
22 checks passed
@picnixz
Copy link
Member

picnixz commented Mar 18, 2024

Thank you!

@jayaddison
Copy link
Contributor Author

Thanks!

@jayaddison jayaddison deleted the tests/linkcheck-add-local-file-existence-coverage branch March 18, 2024 18:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants