[cleanup] deprecate sphinx.testing.util.strip_escseq in favor of sphinx.util.console.strip_colors.
#12186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til.console.strip_colors``.
jayaddison
reviewed
Mar 23, 2024
jayaddison
reviewed
Mar 23, 2024
picnixz
commented
Mar 23, 2024
picnixz
commented
Mar 23, 2024
jayaddison
reviewed
Mar 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sphinx.testing.util.strip_escseqdid not exactly do what its name meant, namely it only stripped ANSI color codes but not all possible ANSI codes. If in the future we must strip ANSI control sequences in general, we should make the currentsphinx.util.console._strip_escape_sequencesfunction public, but for now it is not planned.I took the liberty of having
Finalobjects at module level to avoid modifying them by accident (even though they are private).