Properly support WebP in the image converter #12224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WEBP is not supported in LaTeX - use PNG instead. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Checking mime type of images that might require conversion was broken due to relative path being passed to guess_mimetype() instead of absolute path. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
kartben
changed the title
|
Could you add tests? I'd like to see an example where it fails and succeeds. |
picnixz
added
awaiting:response
AA-Turner
removed
the
awaiting:response
AA-Turner
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Fix mime type detection in image converter and add webp->png conversion.
Feature or Bugfix
Purpose
Although
_image_type_from_filefunction is able to detect a WEBP header, this could not work due to wrong type of path being passed toguess_mimetypefunction. As a result, creating a converter fromimage/webpformat to e.g.image/pngwas not possible.This PR fixes it by both making it possible to have simple extension based detection of webp files, as well as fixing the code for detection based on actual binary header.