Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敡 Narrow typing for Builder.build method #12357

Merged
merged 2 commits into from
Jun 17, 2024
Merged

馃敡 Narrow typing for Builder.build method #12357

merged 2 commits into from
Jun 17, 2024

Conversation

chrisjsewell
Copy link
Member

No description provided.

picnixz
picnixz reviewed May 7, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest having a type alias somewhere (and runtime accessible since we don't correctly support yet literal types guarded by a TYPE_CHECKING guard).

@chrisjsewell chrisjsewell merged commit 1e297bb into sphinx-doc:master Jun 17, 2024
23 checks passed
@chrisjsewell chrisjsewell deleted the type-build-method branch June 17, 2024 10:44
@AA-Turner AA-Turner added this to the 7.4.0 milestone Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
builder internals:typing
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisjsewell @picnixz @AA-Turner @jayaddison