Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Improve Internationalization guide #12377

Merged
merged 10 commits into from
Jun 7, 2024

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented May 16, 2024

Feature or Bugfix

  • Refactoring

Purpose

Fix and update information ins this page.

Detail

  • Documentation needs to mention the new Transifex CLI tool instead of the deprecated transifex-client

Relates

@chrisjsewell
Copy link
Member

Hi @rffontenelle can you confirm this ready for review/merge, as you've made a few changes since opening 😅 (best to set as a Draft until it is ready)

@rffontenelle rffontenelle marked this pull request as draft May 20, 2024 16:29
@rffontenelle rffontenelle marked this pull request as ready for review June 5, 2024 03:50
@rffontenelle
Copy link
Contributor Author

@chrisjsewell Hi, I believe I'm satisfied for the moment. If I come up with other improvements, I'll open another PR in the proper time. Could you please review?

@chrisjsewell chrisjsewell changed the title Improve Internationalization doc DOCS: Improve Internationalization guide Jun 7, 2024
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great cheers!

@chrisjsewell chrisjsewell merged commit da076d1 into sphinx-doc:master Jun 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internationalization doc mentions deprecated transifex-client
2 participants