Fix unwanted * between varargs and keyword only args #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The * parameter must only be present when a holder for positional variable arguments is not present.
| @@ -35,14 +35,18 @@ def f5(x: int, *, y: str, z: str) -> None: | |||
| pass | |||
|
|
|||
|
|
|||
| def f6(x: int = None, y: dict = {}) -> None: | |||
There was a problem hiding this comment.
Is there a particular reason you're inserting a function here, instead of appending it to the list?
There was a problem hiding this comment.
Keeping them properly grouped. I can append instead of inserting if that makes you happy.
|
LGTM. |
|
@lehmannro you're listed as a co-maintainer; do you have push access? Would you mind merging this then? |
|
LGTM too. |
|
Thanks! |
shimizukawa
added a commit
that referenced
this pull request
Oct 18, 2016
shimizukawa
added a commit
that referenced
this pull request
Oct 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The * parameter must only be present when a holder for positional variable arguments is not present.