Fix #1734: Could not translate the caption of toctree directive #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
1734_translate_caption_of_toctree
branch
from
51f00d4
to
d4d6f15
Compare
tk0miya
force-pushed
the
1734_translate_caption_of_toctree
branch
from
d4d6f15
to
9b00c31
Compare
|
Update interaface of I will merge this soon. |
|
LGTM! |
|
@shimizukawa @shibukawa Thank you for reviewing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to translate the caption of toctrees.
I know this is an very ad-hoc fix.
It would be better if we move translation process to writing phase.
@shimizukawa Could you review this and comment please?