Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2435: Slim down quickstarted conf.py #2960

Merged
merged 2 commits into from Oct 12, 2016

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Sep 15, 2016

refs: #2435
I removed almost of commented-out config variables.

@tk0miya tk0miya added type:proposal a feature suggestion internals:config labels Sep 15, 2016
@tk0miya tk0miya added this to the 1.5 milestone Sep 15, 2016
@shimizukawa
Copy link
Member

LGTM with nits.

I think it would be better if "full version of conf.py" sample is pasted in the configuration page of the sphinx documentation ( http://www.sphinx-doc.org/en/stable/config.html ). If the sample is there, we can remove more comment-outed parts of conf.py.

@tk0miya
Copy link
Member Author

tk0miya commented Oct 7, 2016

@shimizukawa AFAIK, there is no "full version of conf.py". At this moment, Sphinx only generates imcomplete version of conf.py.
Did you mean that we should paste current version of conf.py to docs?

@shimizukawa
Copy link
Member

Did you mean that we should paste current version of conf.py to docs?

Yes.

@tk0miya tk0miya force-pushed the 2435_slimdown_default_conf.py branch from 11a8d69 to 576a852 Compare October 11, 2016 11:10
@tk0miya
Copy link
Member Author

tk0miya commented Oct 11, 2016

I just added conf.py as example.

@shimizukawa
Copy link
Member

LGTM!

2016年10月11日(火) 20:10 Takeshi KOMIYA notifications@github.com:

I just added conf.py as example.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2960 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJQR3NgVQrbjy5qHKmSuQjInG1JJYobks5qy263gaJpZM4J99i_
.

@tk0miya tk0miya force-pushed the 2435_slimdown_default_conf.py branch from 576a852 to cbe0ce6 Compare October 12, 2016 09:40
@tk0miya tk0miya merged commit 3496242 into sphinx-doc:master Oct 12, 2016
@tk0miya
Copy link
Member Author

tk0miya commented Oct 12, 2016

Merged!

@shimizukawa
Copy link
Member

GJ!

@tk0miya tk0miya deleted the 2435_slimdown_default_conf.py branch October 19, 2016 10:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants