Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3445: (latex) make \\usepackage[utf8x]{inputenc} usable #3446

Merged
merged 1 commit into from
Feb 26, 2017

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Feb 22, 2017

Relates

in case of utf8x option to inputenc, \DeclareUnicodeCharacter works with decimal, not hexadecimal Unicode code points. Further, it is not needed for handling U+00A0 as it does it automatically.

@jfbu
Copy link
Contributor Author

jfbu commented Feb 22, 2017

MEMO 1: in fact with TeXLive 2016 it is not needed to make \DeclareUnicodeCharacter{00A0}{\nobreakspace } explicitely, because this is already done by utf8 option of inputenc package. (at least since 2016/02/28 v1.1s release of utf8enc.dfu, hence also in updated TeXLive 2015).

MEMO 2: for utf8x , it does it automatically first time it encounters the U+00A0 in document (at least on my locale which has utf8x.def 2004/10/17, and ucs 2013/05/11 v2.2.) Perhaps nevertheless I should add to the PR an explicit \\DeclareUnicodeCharacter{160}{\\nobreakspace} as it gains fraction of microsecond for latex build probably.

@tk0miya
Copy link
Member

tk0miya commented Feb 22, 2017

+0; I'm not good at utf8x package. so I have nothing to say.

@jfbu
Copy link
Contributor Author

jfbu commented Feb 23, 2017

I have no experience myself with it. I know it was much in advance compared to LaTeX kernel, but now LaTeX kernel people have incorporated some of its ideas (in different ways) and people of influence on tex.sx do not seem to like it a lot. However in the case of #3444, I tested that utf8x could handle it without any need of additional preamble configuration. For this reason I will merge this if no objection within a week, thanks for reviewing !

@jfbu
Copy link
Contributor Author

jfbu commented Feb 26, 2017

thanks for review @tk0miya now merging and will update CHANGES (for 1.5.4)

@jfbu jfbu merged commit 8f2b460 into sphinx-doc:stable Feb 26, 2017
@jfbu jfbu added this to the 1.5.4 milestone Feb 26, 2017
@jfbu jfbu deleted the latex-utf8x branch February 26, 2017 08:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants