fix gettext builder that writes pot files unless the content are same without creation date #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without creation date
shibukawa
force-pushed
the
fix/pot_creation_date
branch
from
59060c0
to
8ebc97d
Compare
This was referenced Mar 2, 2017
shimizukawa
added a commit
that referenced
this pull request
Mar 2, 2017
techtonik
reviewed
Mar 11, 2017
| old_body_index = old_content.index('"PO-Revision-Date:') | ||
| new_body_index = new_content.index('"PO-Revision-Date:') | ||
| return ((old_content[:old_header_index] != new_content[:new_header_index]) or | ||
| (new_content[new_body_index:] != old_content[old_body_index:])) |
There was a problem hiding this comment.
It is compares chunk before POT-Creation date and chunk after and including PO-Revision-Date. I guess the later doesn't change, but there might a better option to compare using sets. https://stackoverflow.com/questions/19007383/compare-two-different-files-line-by-line-in-python/19007888#19007888
There was a problem hiding this comment.
Indeed, our template for .po file: POHEADER has fixed PO-Revision-Date. It's immutable.
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
And current time is used for POT-Creation-Date:. so should_write() would return True.
So we have to compare without these headers.
jpmckinney
pushed a commit
to open-contracting/standard
that referenced
this pull request
Feb 6, 2018
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… without creation date
Subject:
Feature or Bugfix
Purpose
Detail
Relates