Filter out duplicate search results #3911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've realised that this approach will not always work - it is possible for |
|
What should I do for this? Are you trying to fix it now? BTW, to understand the problem, I'd like to reproduce the problem. Do you have minimal reproducible project? |
|
Any updates? If none, I will reject this. |
|
I'm closing this now. Feel free to re-reopn this PR again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Filter out duplicate search results
Feature or Bugfix
Bugfix
Purpose
When performing a search using the searchtools.js, if the query includes multiple terms then this can lead to duplicate partial results being added by performObjectSearch().
Detail
This pull request skips duplicate results in displayNextItem() by checking if each result is identical to the last one in the sorted list.