Turn any environment unpickling error into IOError #4048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: allow graceful upgrading Sphinx-1.5 -> Sphinx-1.6
Feature or Bugfix
Purpose
The scenario is:
This gives:
A simple solution is: wrap the
pickle.load(f)
call intry
/except
and change any exception toIOError
. ThatIOError
is then caught higher up, which allows the documentation to build with a message likeMore generally, this pickle is not crucial to building the documentation. Therefore, it should not be a hard error if this pickle is somehow corrupted.